fix: UUID validation on getClaim and ceiling rounding comment - #635
Merged
nonsobethel0-dev merged 1 commit intoSep 25, 2026
Conversation
…ield-Protocol#598, Parashield-Protocol#599, Parashield-Protocol#600, Parashield-Protocol#601) Closes Parashield-Protocol#599 - Add ParseUUIDPipe to getClaim @PARAM decorator so invalid IDs are rejected with a 400 before the database is queried. ParseUUIDPipe was already imported and used on autoProcess; this applies the same pattern to the missing getClaim route. Closes Parashield-Protocol#598 - Add comment to calculatePremium explaining why ceiling rounding is used instead of standard rounding: ceil protects the insurance pool from under-collection by ensuring the pool always collects at least the full actuarial cost of coverage. Issues Parashield-Protocol#600 and Parashield-Protocol#601 are being addressed separately in this same branch.
|
@olywales-stack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nonsobethel0-dev
merged commit Sep 25, 2026
3ae4be6
into
Parashield-Protocol:main
0 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599 - Add ParseUUIDPipe to getClaim @PARAM decorator so invalid IDs are rejected with a 400 before the database is queried. ParseUUIDPipe was already imported and used on autoProcess; this applies the same pattern to the missing getClaim route.
Closes #598 - Add comment to calculatePremium explaining why ceiling rounding is used instead of standard rounding: ceil protects the insurance pool from under-collection by ensuring the pool always collects at least the full actuarial cost of coverage.
Changes
#375 - API versioning strategy
X-API-Versionresponse headerDeprecationheader for v1 withLinkheader pointing to v2 successorx-api-versionheader for API version negotiation#373 - Pagination on policy and claims list endpoints
pageandlimitquery parameters toGET /api/v1/productsendpointgetActiveProductsservice method to support Prisma-based pagination withtake/skipgetClaimsByWalletQuery,getClaimHistory) already had pagination#372 - Rate limiting on claim submission endpoint
limit: 5/60s) toPOST /api/v1/claimsendpoint@Throttledecorator with stricter limits than global throttler (60/60s)#374 - Webhook support for policy/claim status changes
WebhooksServicewith register/unregister/list and status notification methodsWebhooksControllerwithPOST /api/v1/webhooks/registerandGET /api/v1/webhooksendpointspolicy.status.changeeventclaim.status.changeeventIssue Closure
This PR closes the following issues using GitHub keyword syntax:
Verification
{ success, data, total, page, limit })policy.status.change,claim.status.change)