fix(#612,#613,#614,#615): parallel webhooks, response verification, delivery results, SSE cleanup - #637
Merged
nonsobethel0-dev merged 3 commits intoSep 25, 2026
Conversation
…ise.allSettled WebhooksService.notifyPolicyStatusChange and notifyClaimStatusChange delivered webhooks sequentially — a slow webhook blocked delivery to all subsequent registrations. Now uses Promise.allSettled for parallel delivery so one slow endpoint doesn't delay others.
…rification tests and delivery result tests - Parashield-Protocol#613: Test that webhook response signatures are verified when present and that mismatched signatures are rejected - Parashield-Protocol#614: Test that notifyPolicyStatusChange and notifyClaimStatusChange return delivery results with success/failure per registration
… disconnect PolicyController SSE endpoint subscribed to policy status events but had a race condition: if the observable completed before the 'close' event fired, or if close fired multiple times, the cleanup could double-fire or leak. Added idempotent cleanup with a cleanedUp guard, subscriber.closed checks before emitting, and ensured both the teardown function and the close handler share the same cleanup path.
|
@franciscodes-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #612
Closes #613
Closes #614
Closes #615
What changed
notifyPolicyStatusChangeandnotifyClaimStatusChangeto deliver webhooks in parallel usingPromise.allSettledinstead of sequentialfor...ofwithawait. A slow webhook no longer blocks delivery to subsequent registrations.deliverWebhook. When the endpoint provides anX-Webhook-Signature-Responseheader, it is verified against the HMAC of the response body using the shared secret with timing-safe comparison.WebhookDeliveryResult[]with per-registration success/failure status, status codes, and error messages.PolicyControllerSSE endpoint cleanup. Added idempotent cleanup with acleanedUpguard,subscriber.closedchecks before emitting, and ensured both the teardown function and theclosehandler share the same cleanup path to prevent subscription leaks.