fix: JWT log redaction, resilient parallel health checks, operator-only health detail - #640
Merged
nonsobethel0-dev merged 1 commit intoSep 26, 2026
Conversation
… health checks in parallel, and limit detail to operators
|
@ANTIDOT20 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #543
Closes #544
Closes #545
Closes #546
Changes
JwtService.signno longer logs the wallet address, andsignWithRolelogs only the role. The auth controller's existing login log remains the single place a wallet is recorded.errorinstead of hanging the endpoint.Promise.all. Checks inside each group keep their original order, so the combined error messages are unchanged.x-api-key, same key as the operator guard) is presented; comparison is constant-time. Specs cover both views.Scope notes
check()without a request object; only the new specs pass one.src/policy/policy.controller.tsalready fails to parse onmain(unrelated to this change), and the Prisma client was not generated locally, so a full typecheck was not possible; the changed files showed no errors other than the missing generated Prisma types.