Fix/security issues - #664
Merged
nonsobethel0-dev merged 2 commits intoSep 29, 2026
Merged
Conversation
1. GovernanceDao: Add safeguard for division by zero in adaptive quorum - When participation history is empty, fall back to base quorum - Prevents panic on first proposal creation with adaptive quorum enabled - Severity: Medium 2. PolicyEngine: Add oracle_key length validation in buy_policy - Enforce 32 character maximum on oracle_key parameter - Prevents excessively long keys that could cause oracle lookup issues - Aligns on-chain validation with backend constraints - Severity: Medium 3. RiskPool: Add reinsurer interface validation in set_reinsurance - Verify reinsurer implements IReinsurer interface via test call - Prevents malicious/buggy contracts from being set as reinsurer - Protects pool from fraudulent recovery amounts - Severity: High All fixes include inline security comments explaining the issue and solution.
|
@ReinaMaze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nonsobethel0-dev
merged commit Sep 29, 2026
cf814fb
into
Parashield-Protocol:main
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #464
close #465
close #466
close #467