Skip to content

fix: address issues #572-#575 - #646

Merged
nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
trustosaretin:fix/all-4-issues
Sep 24, 2026
Merged

nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
trustosaretin:fix/all-4-issues

Conversation

@trustosaretin

Copy link
Copy Markdown
Contributor

Closes #572, Closes #573, Closes #574, Closes #575

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional or behavioral changes)
  • Performance improvement
  • Documentation update
  • Build / CI configuration change
  • Dependency update
  • Other:

Summary

This PR addresses four issues in the parashield-frontend:

  1. [security] Wallet kit singleton is never cleaned up on disconnect #572 - Wallet kit singleton cleanup: Reset _kit to null in disconnectWallet() so a fresh kit is created on next connect, preventing stale wallet references.
  2. [ux] Policy detail page oracle section has no loading state #573 - Oracle loading state: Initialize useOracleReading hook with loading: true so the loading spinner appears immediately instead of flashing blank content.
  3. [bug] Policy detail page does not handle 404 policy gracefully #574 - 404 policy handling: Distinguish 404 errors from other API errors in usePolicy hook, showing "Policy not found" instead of an error message for missing policies.
  4. [a11y] Modal does not trap focus on first render for NVDA screen reader #575 - Modal focus trap for screen readers: Focus the dialog element on mount first (for NVDA announcement), then move focus to the first interactive element via requestAnimationFrame.

Motivation / Context

Closes #572, Closes #573, Closes #574, Closes #575

- Reset wallet kit singleton on disconnect to prevent stale wallet references (Parashield-Protocol#572)
- Focus dialog element on mount for NVDA screen reader announcement (Parashield-Protocol#575)
- Initialize oracle reading hook with loading state to show spinner immediately (Parashield-Protocol#573)
- Distinguish 404 errors from other errors in usePolicy to show 'not found' gracefully (Parashield-Protocol#574)
@netlify

netlify Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.

Name Link
🔨 Latest commit 8780335
🔍 Latest deploy log https://app.netlify.com/projects/boisterous-sunshine-dd4c4c/deploys/6ab49e9e8e7f7b0008b4b37d

@drips-wave

drips-wave Bot commented Sep 24, 2026

Copy link
Copy Markdown

@trustosaretin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nonsobethel0-dev
nonsobethel0-dev merged commit 25dd977 into Parashield-Protocol:main Sep 24, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants