fix: use lucide-react Search icon instead of unicode emoji (#651) - #657
Merged
nonsobethel0-dev merged 2 commits intoSep 24, 2026
Conversation
…d-Protocol#651) SearchBar rendered a raw 🔍 unicode character instead of an icon component, inconsistent with the rest of the app (NavBar/Toast use X, Breadcrumb uses ChevronRight, all from lucide-react). Replaced with <Search size={16} aria-hidden="true" .../>, keeping the same positioning classes as the emoji span. Marked aria-hidden since it's purely decorative -- the input's own placeholder text already conveys "search," matching the pattern used for other decorative icons in this app. Left the clear button's ✕ character untouched -- out of scope for this issue, which only names the search icon. Verified: npx tsc --noEmit and npm run lint show no new errors, and the existing SearchBar test suite passes (8/8). Closes Parashield-Protocol#651
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verified against current source:
SearchBar.tsxrendered a raw🔍unicode character in a<span>instead of an icon component — confirmed inconsistent with the rest of the app, which useslucide-reactthroughout (NavBar/ToastuseX,BreadcrumbusesChevronRight).Fix
Replaced the emoji span with
<Search size={16} aria-hidden="true" .../>, keeping the same positioning classes the emoji span had. Addedaria-hidden="true"since it's purely decorative — the input's own placeholder text already conveys "search," matching the pattern already used for other decorative icons in this app.Left the clear button's
✕character untouched — out of scope for this issue, which only names the search icon at line 27.Verification
npx tsc --noEmit— no new errorsnpm run lint— no new warnings/errorsnpx vitest run src/__tests__/SearchBar.test.tsx— 8/8 passing (existing suite, unchanged)Test plan
Closes #651