fix: policy detail page bug fixes and improvements - #659
Merged
nonsobethel0-dev merged 4 commits intoSep 24, 2026
Merged
Conversation
…to sticky positioning The policy detail page refetching indicator used fixed positioning which overlapped with the navbar on scroll. Changed to sticky so it stays within the page flow.
…ncated values Screen readers couldn't distinguish between multiple copy buttons with generic labels. Now includes the truncated wallet address or oracle key in each button's label for better accessibility.
Avoids redundant fetches when the user navigates away and back quickly. Policies are cached in a module-level Map with a 30-second TTL, so recently loaded data is reused on re-mount.
…opment mode Raw error details (XDR, simulation results) were logged to console in production, potentially leaking sensitive contract data. Now only logs when import.meta.env.DEV is true.
|
@DeFiVC Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
nonsobethel0-dev
merged commit Sep 24, 2026
49c6218
into
Parashield-Protocol:main
0 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #568, Closes #569, Closes #570, Closes #571
Type of Change
Summary
Four targeted fixes for the policy detail page: refetching indicator positioning, accessible copy button labels, policy caching, and error logging security.
Changes
fixedtostickypositioning so it no longer overlaps with the navbar on scrollusePolicyhook to avoid redundant fetches on quick navigation backContractErrordetail logging behindimport.meta.env.DEVto prevent leaking sensitive data (XDR, simulation results) in productionTesting
Tradeoffs