fix(a11y): expose refreshing state via aria-busy on OracleDataWidget … - #660
Merged
nonsobethel0-dev merged 1 commit intoSep 30, 2026
Conversation
…buttons
The refresh ("↻ Refreshing…") and retry ("Retrying…") buttons already
show a busy label, but screen readers had no programmatic signal that
the widget was refreshing. Adds aria-busy={refreshing} to both buttons
so assistive tech announces the loading state (upstream issue Parashield-Protocol#619).
🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@stephaniepez21-art Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
nonsobethel0-dev
merged commit Sep 30, 2026
bf98bfc
into
Parashield-Protocol:main
0 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #619
Summary
The
OracleDataWidgetrefresh/retry buttons already change their label while arefresh is in flight ("↻ Refreshing…", "Retrying…"), but that state was purely
visual — no programmatic signal for assistive technology. This adds
aria-busy={refreshing}to both buttons, exactly as suggested in the issue:Testing
src/__tests__/OracleDataWidget.a11y.test.tsx: idle →aria-busy="false","true"while refetch is pending, back to"false"after it resolves (both buttons).OracleDataWidget.test.tsx(14 pre-existing) + 3 new a11y tests: 17/17 passing.clean tree; none touch
OracleDataWidget).