Skip to content

fix: hide Skeleton components from screen readers with aria-hidden - #661

Merged
nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
Horpeyehmi:fix/issue-652-a11y-skeleton-components-missing-aria-hidden
Sep 30, 2026
Merged

nonsobethel0-dev merged 1 commit into
Parashield-Protocol:mainfrom
Horpeyehmi:fix/issue-652-a11y-skeleton-components-missing-aria-hidden

Conversation

@Horpeyehmi

Copy link
Copy Markdown

Overview

This PR fixes an accessibility issue where Skeleton components rendered decorative loading placeholders without aria-hidden="true", causing screen readers to announce them as meaningful content. The skeleton container now opts out of the accessibility tree, and tests were added to lock in the behavior.

Related Issue

Changes

♿ Accessibility Fix

  • [MODIFY] src/components/Skeleton.tsx

    • Add aria-hidden="true" to the skeleton container so decorative placeholder content is hidden from assistive technologies.
    • Preserve existing styling, props, and rendering behavior for sighted users.
  • [MODIFY] src/__tests__/Skeleton.test.tsx

    • Add assertions verifying the skeleton container exposes aria-hidden="true".

Verification Results

npm test -- src/__tests__/Skeleton.test.tsx
✅ Skeleton tests passed
Acceptance Criteria Status
Skeleton elements are hidden from screen readers ✅ aria-hidden="true" applied to skeleton container
Loading pages no longer announce skeleton placeholders ✅ Decorative content removed from accessibility tree
Existing skeleton rendering/styling is unchanged ✅ Visual behavior preserved

Closes #652

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@Horpeyehmi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.

Name Link
🔨 Latest commit 8276ab0
🔍 Latest deploy log https://app.netlify.com/projects/boisterous-sunshine-dd4c4c/deploys/6abc454db6fb650008df3fda

@nonsobethel0-dev
nonsobethel0-dev merged commit 73bd43c into Parashield-Protocol:main Sep 30, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y] Skeleton components missing aria-hidden attribute

2 participants