[Accessibility] Validate virtualized-grid keyboard navigation - #170
Merged
BigDella merged 1 commit intoSep 27, 2026
Conversation
|
@SahheedTech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Large Stellar datasets rely on
AccessibleGrid, so a row that is visually present but unreachableby keyboard is a product defect — and the grid had no test covering virtualization boundaries at
all.
The grid now keeps a resilient roving tabindex: focus is tracked by row key rather than row index
(a virtualized list recycles DOM nodes, and sorting or filtering moves rows between indices), the
boundary keys clamp instead of walking off the grid, and focus is restored to a still-rendered cell
when the focused node is recycled out from under it. The new tests cover moving across an unloaded
window, returning to a previously rendered row, focus preservation across data updates, id-uniqueness
after recycling, and axe assertions.
Branch note: the issue template asks for
dev, but this repository has onlymain(
git/ref/heads/devreturns 404 and the branch list ismain+ short-lived feature branches), sothis PR targets
main— the only integration branch that exists.Related Issue
Closes #133
Changes
Grid behaviour
core/ui/AccessibleGrid.tsxfocusedRowKeyRef) plus DOM-focus state, instead of byindex alone, so a reorder or filter does not move the caret to an unrelated row.
clampRow/clampColbound every arrow-key move, and an empty grid returns early rather thancomputing a negative index.
columns[col]) instead of thedestination column, fixing the off-by-one where the wrong column was sorted.
focus, and focus moved out of the grid is deliberately not pulled back.
Tests
core/ui/__tests__/AccessibleGrid.test.tsxaria-rowindexassertions.@testing-librarykeyboard events.Verification Results
devbranch (NOTmain)devdoes not exist in this repository (main+ feature branches only), so this PR targetsmain— see the branch note in the overviewCloses #133Closes #133