Refactor Parcels time strategies into tests.strategies submodule#2602
Merged
VeckoTheGecko merged 6 commits intoParcels-code:mainfrom Apr 28, 2026
Merged
Refactor Parcels time strategies into tests.strategies submodule#2602VeckoTheGecko merged 6 commits intoParcels-code:mainfrom
VeckoTheGecko merged 6 commits intoParcels-code:mainfrom
Conversation
VeckoTheGecko
commented
Apr 28, 2026
| from hypothesis import given | ||
| from hypothesis import strategies as st | ||
|
|
||
| import tests.strategies as pst # parcels strategies |
Contributor
Author
There was a problem hiding this comment.
This import alias is common convention for Hypothesis (and packages that provide hypothesis strategies).
import hypothesis.strategies as st
import xarray.testing.strategies as xrst
# and here
import tests.strategies as pst # <-- parcels strategies
erikvansebille
approved these changes
Apr 28, 2026
VeckoTheGecko
force-pushed
the
push-qowuxozwlnwo
branch
from
8624dc4 to
0369aeb
Compare
for more information, see https://pre-commit.ci
VeckoTheGecko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes it easier to share these strategies between tests.
Also moved
test_datasets.pytodatasets/test_structured.py. This is because we will want to have tests for creating and manipulating output data as well (as part of #2600 ) so this structure would be nice. At the end of last week I started work on #2600 , but since decided to stop in favour of other work. I think these changes are good to get into main regardless.Checklist
mainfor normal development,v3-supportfor v3 support)