Add error message for >4D field input#2605
Open
VeckoTheGecko wants to merge 1 commit intoParcels-code:mainfrom
Open
Add error message for >4D field input#2605VeckoTheGecko wants to merge 1 commit intoParcels-code:mainfrom
VeckoTheGecko wants to merge 1 commit intoParcels-code:mainfrom
Conversation
| "This is not possible, a field cannot have two dimensions on a single axis." | ||
| ) | ||
| seen_axes[ax] = dim_name | ||
| assert len(ax_dims) <= 4 |
Member
There was a problem hiding this comment.
Also raise a more informative error on this assert?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added a check in
assert_all_field_dims_have_axisto assert that field input is <=4D.I have manually tested this with the following:
code
Error
Checklist
mainfor normal development,v3-supportfor v3 support)