Conversation
jbtronics
added a commit
that referenced
this pull request
Sep 20, 2026
This has the same effect as PR #1552 but uses a much more generic approach which can be easily used for other entities
Member
|
Thanks for the PR. I cherry picked the form reset commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues affecting dynamic form collections:
These generic changes were extracted from #1492 following review feedback. This PR contains no parameter-definition, choice-list, filtering, migration, or permission changes.
Implementation
The changes are split into two commits:
Fix resetting dynamic form collectionsIgnore removed parameters during uniqueness validationUniqueEntityconstraint.Verification
A negative-control run against the unmodified
upstream/masterreproduced the issue:With the changes applied:
The repository currently has no DOM/browser test infrastructure for the JavaScript reset behavior, so the modified JavaScript was verified through ESLint and the production asset build.