Repository navigation
Exclude unused Kafka libraries and update .NET to 10.0.13 - #6004
Open
boblangley wants to merge 3 commits into
Open
boblangley wants to merge 3 commits into
boblangley wants to merge 3 commits into
Conversation
rbev
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows installer packages libcurl 8.19.0 through RavenDB's native Kafka client dependencies. That curl version has published vulnerabilities. ServiceControl does not configure RavenDB's Kafka ETL or sink tasks, and the bundled RavenDB license reports both queue features disabled.
Exclude
libcurl.dll,librdkafka.dll, and its C++ companionlibrdkafkacpp.dllfromRavenDBServer.zip. The other server files and dependency manifests remain intact. Kafka functionality would require these native dependencies if enabled. Normal instance upgrades replace the installation directory, so they also remove the excluded DLLs.Add a Windows installation engine test that extracts the actual embedded ZIP and starts its self-contained
Raven.Server.exe. It checks the excluded DLLs, writes and reads a document, queries a static index, and repeats the read/query after restarting the server. This runs inWindows-DefaultCore; existingWindows-Raventests use the separate server supplied byRavenDB.Embedded.Update
RuntimeFrameworkVersionto 10.0.13 to unblock NuGet audit and keep the packaged Microsoft assemblies aligned with the shared runtime. Microsoft identifies PKCS 10.0.13 as the patched version for CVE-2026-70162 and CVE-2026-84008. Pin the transitiveMicrosoft.Extensions.FileProviders.Embeddeddependency to the same runtime version. NuGet audit and assembly-version checks remain enabled.The implementation follows Packaging and Deployment. The PR records the exclusion rationale; the documentation describes the resulting package and test coverage.
Validation
ServiceControlInstaller.Engine.UnitTestsand its project graph on macOS withEnableWindowsTargeting=trueand NuGet audit enabled: no warnings or errors.Raven.Server.exeis present.The first CI run stopped at restore on PKCS audit findings also present on master. A PKCS-only update cleared restore but failed the existing shared-runtime assembly-version checks; the runtime update resolves that mismatch. The same run also hit an Azure CLI Python import deadlock, a Linux RavenDB request timeout, and an MSSQL container port collision. These failures occurred outside the packaged Windows server test and will be checked in the next run.