Repository navigation
Don't fail PackagedRavenDBTests when the temp folder can't be deleted - #6038
Merged
Merged
Conversation
Backports the cleanup change to PackagedRavenDBTests from #5969 on master. On Windows, RavenDB server files can still be locked right after the process exits, which failed the test during cleanup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npink42
approved these changes
Oct 20, 2026
ngallegos
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the
PackagedRavenDBTestscleanup change from:CanPersistAndIndexDocumentsWithoutNativeKafkaDependenciescame torelease-6.21with #6019 (the backport of #6004). On Windows, the RavenDB server files in the temporary folder are sometimes still locked right after the server process exits, so deleting the folder throwsUnauthorizedAccessExceptionand the test fails even though everything it checks passed. It has failed 4 out of 8 Windows-DefaultCore runs on this branch and its PRs. That includes three times in a row on #6033, which is blocking ServiceControl 6.21.3.On
master, #5969 changed the cleanup to retry withDirectory.Deleteand to log a warning instead of failing when the folder still can't be removed. This bringsPackagedRavenDBTests.csin line withmaster. It only touches tests, so it has no milestone or release-notes label.🤖 Generated with Claude Code