Repository navigation
fix(ci): verify Node SDK and update dev-only Undici - #12
Merged
Merged
Conversation
chen21019
changed the title
chen21019
force-pushed
the
security/builder-brotli-20261025
branch
from
October 25, 2026 07:52
82c74d2 to
14a6c85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API Explorer CI gate did not retain the actual Node SDK/host Brotli boundary, and its dev-only jsdom dependency still locked Undici 8.11.2 below the official 8.12.2 security fix for CVE-2026-109869 / GHSA-xjj6-f33q-929c. Update only that transitive lock entry; the root dependency declarations, jsdom version, Node 24.22.1, npm 12.0.2 and browser product version stay unchanged.
Retain the installed jsdom/Undici graph and complete lockfile, the actual official Node SDK version and dynamic-library linkage, Ubuntu runner Brotli package versions, and three ordinary Brotli round trips in the existing checksummed gate artifact. The gate rejects Node unexpectedly linked to host Brotli and explicitly avoids treating host-library presence as source-patch or reachability proof. This Ubuntu runner has no Debian bookworm builder, so no Debian package is installed on it.
Validation: official Undici advisory/release and registry tarball integrity were checked; the lock comparison confirms only node_modules/undici changes (8.11.2 -> 8.12.2, dev-only). YAML/embedded Python parse and git diff --check pass. Required CI retains the ordinary jsdom/product tests, byte-for-byte double build, complete npm audits and existing security gate. No app/API/UI source, product tag or publication changes are included.
Official fix: GHSA-xjj6-f33q-929c
Release: https://github.com/nodejs/undici/releases/tag/v8.12.2