Skip to content

Add support for Baryanic Leylines (Disciple of Varashta)#1804

Open
awlego wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
awlego:baryanic-leylines
Open

Add support for Baryanic Leylines (Disciple of Varashta)#1804
awlego wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
awlego:baryanic-leylines

Conversation

@awlego
Copy link
Copy Markdown

@awlego awlego commented Apr 23, 2026

Description of the problem being solved:

Adds support for Baryanic Leylines (Disciple of Varashta). The tree entry for "Non-Unique Time-Lost Jewels have 40% increased radius" existed but had no parser, so allocating the notable did nothing.

  • ModParser.lua parses the stat into a NonUniqueTimeLostJewelRadius INC mod.
  • Data.lua adds four precomputed +40% radius tiers plus a resolveTimeLostRadiusIndex helper keyed by percent.
  • CalcSetup.lua and PassiveTreeView.lua call the helper so in-radius calcs, the socket ring, and node tooltips all use the upgraded radius on non-unique Time-Lost jewels.
  • ModCache.lua regenerated; new spec added.

Steps taken to verify a working solution:

  • Launched PoB from the dev branch plus this change, picked a Sorceress, allocated Disciple of Varashta → Baryanic Leylines.
  • With Alt held over the notable, confirmed the stat line parses as NonUniqueTimeLostJewelRadius INC 40
  • Socketed a non-unique Time-Lost Ruby with an explicit Small Passives in Radius also grant X% roll into an allocated jewel socket; recorded which passives it affected before allocating Baryanic Leylines.
  • Allocated Baryanic Leylines and confirmed via Alt-hover on individual passives that a node previously outside the base radius now receives the jewel's bonus (e.g. "+3% increased Armour from the Time-Lost Jewel"), and that the ring drawn on the tree for the socket visibly expands.
  • De-allocated Baryanic Leylines and confirmed both the affected-passive list and the drawn ring return to baseline.
  • Confirmed Against the Darkness (unique Time-Lost Diamond) is unaffected — its radius stays the same with Baryanic Leylines allocated, per the "Non-Unique" qualifier.
  • Added TestBaryanicLeylines_spec.lua

Link to a build that showcases this PR:

Before screenshot:

(without Baryonic Leylines)
image
(with Baryonic Leylines)
image
(and a before shot of a passive outside the ring)
image

After screenshot:

Showing that the Baryanic Leylines node shows that it is supported and the effects it will have on the build.
image
Same build/view on this branch, ring now visibly expanded and a previously-unaffected passive showing the jewel's inherited stats in its tooltip.
image


Note on CI

Running the repo's test suite locally against this branch:

  • run_tests: 106 successes / 0 failures / 0 errors, including the two new TestBaryanicLeylines_spec.lua tests.
  • check_modcache: fails — but with an identical 22-line pair-cache drift already present on upstream/dev (last green run 2026-03-14; every push since 2026-03-26 has failed with the same diff). My change to ModCache.lua is a single-line entry for Non-Unique Time-Lost Jewels have 40% increased radius.

Parse "Non-Unique Time-Lost Jewels have X% increased radius" into a
NonUniqueTimeLostJewelRadius modifier. When the build has the modifier,
non-unique Time-Lost Jewels swap to a precomputed +40% radius tier for
the in-radius passive computation and for the socket ring drawn on the
tree. Regenerated ModCache.lua accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant