Add admin email composer with mocked CSV-backed templates#27
Open
RandyJDean wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
RandyJDean
force-pushed
the
06-08-add_first_component_of_admin_email_page
branch
2 times, most recently
from
7c9e057 to
83c9fdd
Compare
RandyJDean
changed the title
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (06/16/26)2 reviewers were added to this PR based on Henry Chen's automation. |
RandyJDean
force-pushed
the
graphite-base/27
branch
from
f344e64 to
ef1f301
Compare
RandyJDean
force-pushed
the
06-08-add_first_component_of_admin_email_page
branch
from
83c9fdd to
e2fbe95
Compare
RandyJDean
changed the base branch from
graphite-base/27
to
emails_connect_backend_to_frontend_component
This was referenced Jun 19, 2026
RandyJDean
force-pushed
the
06-08-add_first_component_of_admin_email_page
branch
from
e2fbe95 to
7058bfe
Compare
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+143
to
+149
| notifications.show({ | ||
| color: result.failed > 0 ? "yellow" : "green", | ||
| icon: <IconCheck size={18} />, | ||
| message: `Sent ${result.sent}, failed ${result.failed}`, | ||
| title: "Email send complete", | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Notification title is always "Email send complete" even when there are failures. This is inconsistent with the alert shown in lines 172-175 which conditionally displays "Email send completed with failures".
notifications.show({
color: result.failed > 0 ? "yellow" : "green",
icon: <IconCheck size={18} />,
message: `Sent ${result.sent}, failed ${result.failed}`,
title: result.failed > 0 ? "Email send completed with failures" : "Email send complete",
});
Suggested change
| notifications.show({ | |
| color: result.failed > 0 ? "yellow" : "green", | |
| icon: <IconCheck size={18} />, | |
| message: `Sent ${result.sent}, failed ${result.failed}`, | |
| title: "Email send complete", | |
| }); | |
| }; | |
| notifications.show({ | |
| color: result.failed > 0 ? "yellow" : "green", | |
| icon: <IconCheck size={18} />, | |
| message: `Sent ${result.sent}, failed ${result.failed}`, | |
| title: result.failed > 0 ? "Email send completed with failures" : "Email send complete", | |
| }); | |
| }; | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Arshadul-Monir
approved these changes
Jun 22, 2026
isabellalam12
changed the base branch from
emails_connect_backend_to_frontend_component
to
graphite-base/27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.