Fix/web debug url#1431
Closed
ndorin wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the WebSocket debug session endpoint by enhancing URL information returned to clients and by managing CS-LAN port forwarding more safely, while also adding base-path context to messenger status messages.
Changes:
- Add
MessageBasePathinto posted device status messages for MobileControl messengers. - Update debug session GET response to include a
fallbackUrl, and add CS-LAN port-forwarding with an inactivity timeout. - Add
HasActiveConnectionsto the debug WebSocket sink to support timeout-based port-forward cleanup.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.MobileControl.Messengers/Messengers/MessengerBase.cs | Adds MessageBasePath to outgoing status messages so clients can build correct paths/URLs. |
| src/PepperDash.Essentials.Core/Web/RequestHandlers/DebugSessionRequestHandler.cs | Enhances debug session endpoint: port-forwarding + timeout cleanup and returns a fallback URL. |
| src/PepperDash.Core/Logging/DebugWebsocketSink.cs | Adds connection-awareness (HasActiveConnections) to support port-forward timeout behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
53
to
+54
| var port = 0; | ||
| string csIp = null; |
Comment on lines
+71
to
+75
| csIp = CrestronEthernetHelper.GetEthernetParameter( | ||
| CrestronEthernetHelper.ETHERNET_PARAMETER_TO_GET.GET_CURRENT_IP_ADDRESS, csAdapterId); | ||
|
|
||
| if (port > 0) | ||
| { |
Comment on lines
+267
to
270
| message.MessageBasePath = MessagePath; | ||
|
|
||
|
|
||
| var token = JToken.FromObject(message); |
Comment on lines
232
to
237
| Debug.LogInformation("Starting Websocket Server on port: {0}", port); | ||
|
|
||
|
|
||
|
|
||
|
|
||
| Start(port, CertPath, _certificatePassword); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.