Socket connection issues#84
Open
ngenovese11 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a WebSocket connection bug in the middleware where the room status request was incorrectly validating the optional roomKey parameter instead of the computed currentRoomKey variable. Additionally, the package-lock.json has been updated with npm's peer dependency metadata.
Changes:
- Fixed bug in
requestRoomStatusfunction that was checking the wrong variable in validation logic - Updated package-lock.json with "peer": true flags for dependencies that are both dev and peer dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/store/middleware/websocketMiddleware.ts | Fixed validation logic to check currentRoomKey instead of the parameter roomKey, ensuring connection works even when roomKey param is undefined but state has a valid room key |
| package-lock.json | Automatic npm metadata update adding "peer": true flags to dependencies listed in both devDependencies and peerDependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating other issues, I found this. Not sure if it is a true bug, I definitely hit a problem where the roomKey was null and the socket wouldn't connect. Not able to reproduce though. Could you review?