fix(ci): resolve js-yaml override conflict breaking release workflow#424
Merged
Conversation
Contributor
✅ Visual Regression Test ResultsStatus: ✅ All visual tests passed! All screenshots match the baseline. No visual regressions detected! 🎉 |
Contributor
⚡ Performance Benchmark Results✅ Build Time Benchmarks: PASSED✅ Bundle Size Benchmarks: PASSED❌ Runtime Vitals Benchmarks: FAILED📝 Note: Detailed results are available in the job logs. 🎯 Performance Budgets:
Updated: 2026-05-15T17:49:32.863Z |
Contributor
♿ Accessibility Test ResultsOverall Status: ✅ 0/0 tests passed 🦮 WCAG 2.1 AA ComplianceNo WCAG test results available ⌨️ Keyboard NavigationNo keyboard navigation test results available 📊 Detailed ReportDownload the full HTML accessibility report from the workflow artifacts for:
🔍 Testing ChecklistOur accessibility tests verify:
Powered by @axe-core/playwright and Playwright |
This was referenced May 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow was failing at the
Exit prerelease modestep with:Root Cause
PR #423 added a scoped override
"read-yaml-file>js-yaml": "^3"to fix this, but left the conflicting global override in place:In pnpm's override resolution, the global
js-yaml: >=4.1.1override stomped the scoped one, soread-yaml-filestill got js-yaml v4 (which removedyaml.safeLoad). The lockfile snapshot confirmed it:read-yaml-file@1.1.0was still resolvingjs-yaml: 4.1.1even after #423.Additionally, PR #423 introduced inconsistent tab indentation in
package.jsonfor the affected override entries.Fix
"js-yaml": ">=4.1.1"override. All workspace packages already pull js-yaml v4 from their ownpackage.jsondependencies — the global override was redundant and harmful here."read-yaml-file>js-yaml": "^3"override now correctly applies, givingread-yaml-fileits own nestedjs-yaml@3.14.2.pnpm installto regenerate the lockfile with the correct snapshot.Verification
After
pnpm install,read-yaml-file@1.1.0resolves tojs-yaml@3.14.2✅pnpm changeset --version→2.31.0✅node -e "require('@changesets/cli')"→ no errors ✅read-yaml-filehas its own nestednode_modules/js-yaml@3.14.2✅