Skip to content

fix(ci): resolve js-yaml override conflict breaking release workflow#424

Merged
perasperaactual merged 1 commit into
devfrom
fix/release-js-yaml-compat
May 15, 2026
Merged

fix(ci): resolve js-yaml override conflict breaking release workflow#424
perasperaactual merged 1 commit into
devfrom
fix/release-js-yaml-compat

Conversation

@perasperaactual
Copy link
Copy Markdown
Contributor

Problem

The release workflow was failing at the Exit prerelease mode step with:

🦋  error Error: Function yaml.safeLoad is removed in js-yaml 4. Use yaml.load instead

Root Cause

PR #423 added a scoped override "read-yaml-file>js-yaml": "^3" to fix this, but left the conflicting global override in place:

"js-yaml": ">=4.1.1",           ← global: forced ALL js-yaml to v4, including for read-yaml-file
"read-yaml-file>js-yaml": "^3"  ← scoped: silently lost — global wins

In pnpm's override resolution, the global js-yaml: >=4.1.1 override stomped the scoped one, so read-yaml-file still got js-yaml v4 (which removed yaml.safeLoad). The lockfile snapshot confirmed it: read-yaml-file@1.1.0 was still resolving js-yaml: 4.1.1 even after #423.

Additionally, PR #423 introduced inconsistent tab indentation in package.json for the affected override entries.

Fix

  • Removed the conflicting global "js-yaml": ">=4.1.1" override. All workspace packages already pull js-yaml v4 from their own package.json dependencies — the global override was redundant and harmful here.
  • The scoped "read-yaml-file>js-yaml": "^3" override now correctly applies, giving read-yaml-file its own nested js-yaml@3.14.2.
  • Fixed tab → 4-space indentation for the entries added by fix(deps): scope js-yaml override to restore changesets compatibility #423.
  • Ran pnpm install to regenerate the lockfile with the correct snapshot.

Verification

After pnpm install, read-yaml-file@1.1.0 resolves to js-yaml@3.14.2

read-yaml-file@1.1.0:
  dependencies:
    js-yaml: 3.14.2  ✅  (was 4.1.1 💀)

pnpm changeset --version2.31.0
node -e "require('@changesets/cli')" → no errors ✅
read-yaml-file has its own nested node_modules/js-yaml@3.14.2

@github-actions
Copy link
Copy Markdown
Contributor

✅ Visual Regression Test Results

Status: ✅ All visual tests passed!

All screenshots match the baseline. No visual regressions detected! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

⚡ Performance Benchmark Results

✅ Build Time Benchmarks: PASSED

✅ Bundle Size Benchmarks: PASSED

❌ Runtime Vitals Benchmarks: FAILED

📝 Note: Detailed results are available in the job logs.

🎯 Performance Budgets:

  • Build time: <70s total
  • First-load JS: <100KB gzipped
  • FCP: <1.5s, LCP: <2.5s, TTI: <3s

Updated: 2026-05-15T17:49:32.863Z

@github-actions
Copy link
Copy Markdown
Contributor

♿ Accessibility Test Results

Overall Status: ✅ 0/0 tests passed

🦮 WCAG 2.1 AA Compliance

No WCAG test results available

⌨️ Keyboard Navigation

No keyboard navigation test results available


⚠️ No accessibility tests were executed. Check the workflow logs for setup issues.

📊 Detailed Report

Download the full HTML accessibility report from the workflow artifacts for:

  • Detailed WCAG violation descriptions
  • Specific element selectors and fixes
  • Color contrast issues
  • Keyboard navigation flow analysis

🔍 Testing Checklist

Our accessibility tests verify:

  • ✅ WCAG 2.1 Level AA compliance
  • ✅ Color contrast in light and dark modes
  • ✅ Tab key navigation through all interactive elements
  • ✅ Focus indicators are visible
  • ✅ No keyboard traps
  • ✅ Skip links and ARIA landmarks
  • ✅ Screen reader compatibility

Powered by @axe-core/playwright and Playwright

@perasperaactual perasperaactual merged commit b450c08 into dev May 15, 2026
6 of 7 checks passed
@perasperaactual perasperaactual deleted the fix/release-js-yaml-compat branch May 15, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant