Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/tools/taskStatusPolicy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,10 @@
export function isTerminalTaskTransition(current: unknown, requested: string): boolean {
return current === "Done" && requested !== "Done";
}

export function dispatchStateForStatus(status: string): "queued" | "working" | "review" | "completed" {
if (status === "In progress") return "working";
if (status === "Review") return "review";
if (status === "Done") return "completed";
return "queued";
}
6 changes: 5 additions & 1 deletion src/tools/updateTaskStatus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { db } from "../firestore.js";
import { logActivity } from "../activityEvents.js";
import type { Tool } from "./types.js";
import { redactClaimTokens } from "./outputSanitizer.js";
import { isTerminalTaskTransition } from "./taskStatusPolicy.js";
import { dispatchStateForStatus, isTerminalTaskTransition } from "./taskStatusPolicy.js";

const ProofSchema = z
.object({
Expand Down Expand Up @@ -158,7 +158,11 @@ export const updateTaskStatus: Tool<typeof InputSchema> = {
// Terminal statuses release the worker-protocol flag.
if (effectiveStatus === "Done" || effectiveStatus === "Review") {
patch.workerProtocol = FieldValue.delete();
patch.claim = FieldValue.delete();
patch.nextDispatchAtMs = FieldValue.delete();
patch.lastDispatchError = FieldValue.delete();
}
patch.dispatchState = dispatchStateForStatus(effectiveStatus);

await taskRef.update(patch);

Expand Down
14 changes: 13 additions & 1 deletion tests/task-status.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { describe, expect, it } from "vitest";

import { isTerminalTaskTransition } from "../src/tools/taskStatusPolicy.js";
import {
dispatchStateForStatus,
isTerminalTaskTransition,
} from "../src/tools/taskStatusPolicy.js";

describe("isTerminalTaskTransition", () => {
it.each(["Backlog", "In progress", "Review"])(
Expand All @@ -15,3 +18,12 @@ describe("isTerminalTaskTransition", () => {
expect(isTerminalTaskTransition("In progress", "Done")).toBe(false);
});
});

describe("dispatchStateForStatus", () => {
it("maps worker status updates to stable user-facing progress states", () => {
expect(dispatchStateForStatus("Backlog")).toBe("queued");
expect(dispatchStateForStatus("In progress")).toBe("working");
expect(dispatchStateForStatus("Review")).toBe("review");
expect(dispatchStateForStatus("Done")).toBe("completed");
});
});
Loading