landing: fix em dashes and the word marketing in site metadata - #273
Open
JulioMCruz wants to merge 1 commit into
Open
landing: fix em dashes and the word marketing in site metadata#273JulioMCruz wants to merge 1 commit into
JulioMCruz wants to merge 1 commit into
Conversation
The root metadata renders on every page and in every link preview, so two copy-convention breaks were shipping site-wide. - "Start free—no technical skills required" becomes "Start free, no technical skills required" (OG_DESC in layout, page description) - "marketing" becomes "growth" in the same sentence, matching the Growth Agency naming already used in the product - em dashes in the OG image alt and in the two JSON-LD descriptions replaced with a colon or comma Scope is human-facing strings only. Em dashes inside code comments are left alone, and the internal "marketing" preset ids are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root metadata in
app/layout.tsxandapp/page.tsxrenders on every page and in every link preview, so two copy-convention breaks were shipping site-wide. Found while verifying the/deckdeploy in #272.What changed
layout.tsxOG_DESC,page.tsxdescriptionlayout.tsxOG image altpage.tsxJSON-LD org descriptionpage.tsxJSON-LD product descriptionmarketingbecomesgrowth, matching the Growth Agency naming already used in the product (TeamTemplateCard.tsxmaps the legacymarketingkey to the label "Growth").Scope
Deliberately narrow, human-facing strings only:
layout.tsx:108,page.tsx:13/21/33/36). They are not copy.marketingpreset ids are untouched (agentPresets.ts,companyTemplates.ts,skillsCatalog.ts,agentVisuals.ts). Renaming those would change data, not copy.The word
marketingstill appears in user-visible copy on other routes (/solutions,/ai-teams-for-small-business,businessWorkflowsin the i18n locales) and in thept/fr/es/ittranslations. That is a larger copy sweep and is not in this PR.Verification
npm run typecheckcleannpx eslint app/layout.tsx app/page.tsxcleanProduction is not updated by merging: this needs the manual rsync + docker compose build on the VPS. Because it is root metadata, it affects the landing and every public route, not just
/deck.