Remove replay-web feature flag - #1121
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the replay-web feature-flag gating from the file viewer now that ReplayWeb is fully enabled in all environments, and updates the associated unit tests to reflect the always-on behavior for web archive records.
Changes:
- Removed
FeatureFlagServiceinjection andreplay-webflag checks fromFileViewerComponent. - Always computes
replayUrlviagetReplayUrl(), which already returnsnullfor non–web archive records. - Updated component tests to stop mocking feature flags and to validate
replayUrlbehavior based on record type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/file-browser/components/file-viewer/file-viewer.component.ts | Removes replay-web feature-flag dependency and sets replayUrl unconditionally (still type-gated inside getReplayUrl()). |
| src/app/file-browser/components/file-viewer/file-viewer.component.spec.ts | Removes feature-flag mocking and updates replay URL tests to align with the new always-on behavior for web archives. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1db817c to
093d92e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
- Coverage 52.33% 52.15% -0.19%
==========================================
Files 354 354
Lines 12093 12091 -2
Branches 2186 2185 -1
==========================================
- Hits 6329 6306 -23
- Misses 5538 5559 +21
Partials 226 226 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
left a comment
There was a problem hiding this comment.
Looks straight forward, LGTM.
Now that the feature is complete and enabled across all environments it is time to remove the feature flag. Issue #1120 Remove ReplayWeb feature flag
093d92e to
dd085b9
Compare
This PR removes reference to the
replay-webfeature flag now that it's deployed and enabled across all environments.Resolves #1120