Mark the Create Archive checklist item as done - #1128
Open
aasandei-vsp wants to merge 1 commit into
Open
Conversation
The Create Archive checklist item would never get checked as done, so the user would never see the list as 100%. The Create Archive is marked as done in the FE, because a user needs to have an archive in order to land on the private workspace. Issue: PER-10681
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
==========================================
- Coverage 52.33% 52.28% -0.06%
==========================================
Files 354 354
Lines 12093 12099 +6
Branches 2186 2187 +1
==========================================
- Hits 6329 6326 -3
- Misses 5538 5546 +8
- Partials 226 227 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
approved these changes
Aug 7, 2026
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
This looks good! I went through the whole checklist and it all worked beautifully. I wonder, separately, if we could set the checklist item true on the backend when the archive is created.
| }, | ||
| ], | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Okay, I think I see what's happening. Is this to reset the API response to what it would be in a base case, before editing the checklistItems in the service?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Create Archive checklist item would never get checked as done, so the user would never see the list as 100%. The Create Archive is marked as done in the FE, because a user needs to have an archive in order to land on the private workspace.
Issue: PER-10681
Steps to test
EXPECTED: The "Create Archive" item on the checklist is checked and the progress bar is at 14%.
EXPECTED: The steps on the checklist get checked correctly and the progress bar updates accordingly.