Skip to content

fix(windows-ui): render PdfView pages natively #8717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
proggeramlug wants to merge 1 commit into from
Closed

fix(windows-ui): render PdfView pages natively #8717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/perry-ui-windows/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ windows = { version = "0.62", features = [
# SystemMediaTransportControls / DisplayUpdater / MusicDisplayProperties
# (#367 — volume HUD media tile, headphone media keys, Edge Now Playing).
"Media",
# PdfView (#6613) — decode native PDF pages to an in-memory PNG via
# Windows.Data.Pdf, then paint them in the Win32 widget with GDI+.
"Data_Pdf",
"Storage",
"Storage_Streams",
# WinHTTP — URL-fetched images on Windows (Image(url, alt) +
# ImageGallery URLs). Mirrors the macOS NSURL/NSData path: native
Expand Down
5 changes: 2 additions & 3 deletions crates/perry-ui-windows/src/ffi/rich_pdf_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ pub extern "C" fn perry_ui_rich_text_toggle_underline(h: i64) {
widgets::rich_text::toggle_underline(h)
}

// PdfView (#516) — Win32 stub-with-state. STATIC label shows
// "[PDF: name — page X/Y @ Z%]" on load + nav. Real page-bitmap
// rendering via `Windows.Data.Pdf` WinRT or PDFium is a follow-up.
// PdfView (#516 / #6613) — native page decoding via Windows.Data.Pdf,
// painted into a subclassed Win32 control with GDI+.
#[no_mangle]
pub extern "C" fn perry_ui_pdf_view_create(w: f64, h: f64) -> i64 {
widgets::pdf_view::create(w, h)
Expand Down
Loading
Loading