Skip to content

ci: unblock release parity and current-main warnings - #8851

Merged
proggeramlug merged 2 commits into
mainfrom
fix/release-http-agent-known-failure
Aug 26, 2026
Merged

ci: unblock release parity and current-main warnings#8851
proggeramlug merged 2 commits into
mainfrom
fix/release-http-agent-known-failure

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What

Evidence

r17 Full: https://github.com/PerryTS/perry/actions/runs/32935157745
Parity job: https://github.com/PerryTS/perry/actions/runs/32935157745/job/98076809981
Parity artifact: https://github.com/PerryTS/perry/actions/runs/32935157745/artifacts/9597975431

Node exits 0. Perry prints the expected true and 1250, then does not terminate before the harness deadline. The ratchet will fail stale once the fixture passes and require this entry to be removed with the product fix.

The first PR run also exposed ten unused-import errors already present on current main after #8847: https://github.com/PerryTS/perry/actions/runs/32945577563/job/98105537416. The follow-up commit removes exactly those unused imports; executable compiler logic is unchanged.

Local checks

  • cargo fmt --all -- --check
  • python3 scripts/parity_known_failures.py --self-test
  • python3 scripts/parity_known_failures.py --audit
  • jq empty test-parity/known_failures.json
  • git diff --check

No publisher was dispatched and no npm/tag side effects occurred.

Summary by CodeRabbit

  • Documentation
    • Updated release notes to reflect Linux Parcel watcher and HTTP Agent lifecycle gaps.
    • Added information about restored warning-free compiler builds.
  • Tests
    • Documented a Linux-specific known test failure involving HTTP Agent connection cleanup after server shutdown.
  • Bug Fixes
    • Improved compiler output by addressing warnings in packed numeric loop processing.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a309b78-b3a7-4f7b-838a-7347bdd6c1c2

📥 Commits

Reviewing files that changed from the base of the PR and between 7901007 and d990d91.

📒 Files selected for processing (3)
  • changelog.d/8851-release-main-warnings.md
  • crates/perry-codegen/src/expr/index_set.rs
  • crates/perry-codegen/src/expr/index_set_packed_loop.rs

Included review availability: Your plan provides up to 8 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The PR records a Linux HTTP Agent lifecycle timeout as a known parity failure, updates the related changelog, and narrows imports in packed-loop index-store lowering modules.

Changes

Linux parity tracking

Layer / File(s) Summary
Record Linux parity gap
test-parity/known_failures.json, changelog.d/8841-release-parity-budget.md
The known-failure registry records the Linux HTTP Agent lifecycle timeout. The changelog describes the Linux Parcel watcher and HTTP Agent lifecycle gaps.

Codegen import cleanup

Layer / File(s) Summary
Narrow packed-loop lowering imports
crates/perry-codegen/src/expr/index_set.rs, crates/perry-codegen/src/expr/index_set_packed_loop.rs, changelog.d/8851-release-main-warnings.md
The index-store lowering modules remove unused and wildcard imports. The changelog records warning-free compiler builds.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d990d

The PR records a scoped Linux parity exception, removes reported unused imports, and updates release notes without changing executable compiler behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies both main changes: release-parity updates and current-main warning cleanup.
Description check ✅ Passed The description explains the parity failure, issue tracking, warning cleanup, changelog updates, evidence, validation commands, and side-effect status. It does not use the template headings or include…
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the parity failure, issue tracking, warning cleanup, changelog updates, evidence, validation commands, and side-effect status. It does not use the template headings or include the checklist, but the required information is mostly present.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-http-agent-known-failure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug proggeramlug changed the title ci: ratchet r17 HTTP Agent parity blocker ci: unblock release parity and current-main warnings Aug 26, 2026
@proggeramlug
proggeramlug merged commit d9d39a6 into main Aug 26, 2026
49 checks passed
@proggeramlug
proggeramlug deleted the fix/release-http-agent-known-failure branch August 26, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant