fix(doc-tests): restore Fastify examples with per-example auto-optimization - #9820
fix(doc-tests): restore Fastify examples with per-example auto-optimization#9820proggeramlug wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe doc-test harness now parses ChangesDoc-test auto-optimize support
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This restores Fastify documentation examples to CI while keeping ordinary examples on prebuilt libraries. The restored examples compile without running servers, and no current merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant DocExample as Doc example
participant DocTests as doc-tests
participant Perry as perry compiler
DocExample->>DocTests: declares requires: auto-optimize
DocTests->>Perry: compile without PERRY_NO_AUTO_OPTIMIZE
Perry-->>DocTests: compilation result
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 6 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on |
Restore the three Fastify documentation examples excluded from the host doc-test CI run. Each example declares
// requires: auto-optimize; the harness removesPERRY_NO_AUTO_OPTIMIZEonly from that example's compiler process, allowing its specialized Fastify libraries to be built. Ordinary examples retain the prebuilt-library setting. The examples keep their existingrun: falsebehavior and participate in the normal pass/fail report, including compilation failures.Remove the exclusions from both macOS and Windows workflow commands, document the banner, and reject unknown requirements so a typo cannot silently defeat it. The shared compiler-environment handling also applies to cross-compilation.
Closes #8475. No version bump.
Validation:
external-fastify-pump.-D warnings, and crate Clippy pass. Clippy reports two unchanged warnings (lint.rssorting and the existing eight-argumentrun_one).Local builds used release codegen-units=16 and LTO disabled through environment overrides. No source build profile changed. These examples are compile-only because they need servers or external services; Windows execution remains for CI.
Summary by CodeRabbit
Documentation
Bug Fixes