test: audit Solid client reactivity under native compilation - #9821
test: audit Solid client reactivity under native compilation#9821proggeramlug wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a Solid 1.9.15 release fixture. It tests reactivity, stores, universal renderer operations, output parity, and native compilation. ChangesSolid reactivity release fixture
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This adds a locked Solid reactivity fixture and associated verification coverage. No current merge-blocking risk is established. Sequence Diagram(s)sequenceDiagram
participant FixtureScript as fixture.sh
participant NodeOracle as Node oracle
participant PerryCompiler as Perry compiler
participant OutputCheck as output comparison
FixtureScript->>NodeOracle: run browser-conditioned fixture
NodeOracle->>OutputCheck: produce runtime output
FixtureScript->>OutputCheck: compare output with expected.txt
FixtureScript->>PerryCompiler: compile with cache bypassed
PerryCompiler->>FixtureScript: report discovered native modules
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on |
Solid defaults to its non-reactive server build under Perry’s Node-compatible package resolution. Add a locked Solid 1.9.15 fixture that uses the existing package aliases to select the client core and store consistently, including their transitive imports.
The release package sweep now audits signals, memos, batching, dynamic dependencies, cleanup, store updates and keyed reconciliation, plus the real universal renderer’s ordering, node identity, text updates, and disposal over an in-memory host. The fixture checks the Node browser-condition oracle and rejects JavaScript fallback modules. This completes the initial compilePackages audit requested in #4644; the native UI adapter and Solid JSX transform remain open.
Validation:
No version bump.
Summary by CodeRabbit
Tests
Documentation