test(runtime): cover for-in visited levels across GC - #9902
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughAdds a parity test for issue Changesfor-in GC regression
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds regression coverage for GC-sensitive prototype traversal during for-in iteration without changing runtime behavior. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f781e08 to
6f0f774
Compare
|
Landed on |
The runtime fix for #9869 is already on main, but the retained prototype levels had no parity regression that forces collection between recording a level and rebuilding the deferred shadow set. This fixture uses a keyed receiver, an empty middle prototype, and a keyed ancestor: middle-level key-array allocation evacuates the retained receiver, then the ancestor triggers the shadow rebuild and duplicate-key filter.
Validation:
scripts/run_lint_gates.sh: all 64 gates passed, 2 CI-only checks skipped locallyFixes #9869
Summary by CodeRabbit
for-initeration across a multi-level prototype chain.