Skip to content

fix(tls): preserve dynamic peer certificates #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
proggeramlug wants to merge 1 commit into from
Closed

fix(tls): preserve dynamic peer certificates #9911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/9911-tls-peer-certificate-dispatch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix dynamic `TLSSocket.getPeerCertificate()` calls from the native net extension so they return the full negotiated certificate. Certificate inspection now preserves the peer identity across server secure-context rotation.
9 changes: 5 additions & 4 deletions crates/perry-ext-net/src/dispatch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ fn socket_method_name(prop: &str) -> Option<&'static [u8]> {
"upgradeToTLS" => Some(b"upgradeToTLS"),
"getSession" => Some(b"getSession"),
"isSessionReused" => Some(b"isSessionReused"),
"getPeerCertificate" => Some(b"getPeerCertificate"),
// The primary stdlib dispatcher owns `getPeerCertificate`: it builds
// the complete legacy certificate object from the DER recorded at the
// handshake. Claiming it here returned the extension's reduced JSON
// facade, whose optional CN is populated only for adopted HTTPS
// sockets, so direct `tls.connect()` handles produced `{}`.
"setDefaultEncoding" => Some(b"setDefaultEncoding"),
"cork" => Some(b"cork"),
"uncork" => Some(b"uncork"),
Expand Down Expand Up @@ -281,9 +285,6 @@ unsafe fn socket_method(handle: i64, method: &str, args: &[f64]) -> Option<f64>
}
"getSession" => nanbox_ptr(crate::js_ext_net_socket_tls_session(handle)),
"isSessionReused" => crate::js_ext_net_socket_tls_session_reused(handle),
"getPeerCertificate" => {
json_str_to_value(crate::js_ext_net_socket_peer_certificate_json(handle))
}
"once" if args.len() >= 2 => {
crate::js_net_socket_once(handle, unbox_to_i64(args[0]), unbox_to_i64(args[1]));
nanbox_handle(handle)
Expand Down
Loading