Repository navigation
Use weight file from SD pipeline - #397
Merged
Merged
Conversation
thomaswilliamsastro
force-pushed
the
sd-weighting
branch
2 times, most recently
from
September 16, 2026 14:15
5336a87 to
3174210
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
=========================================
- Coverage 7.96% 7.95% -0.01%
=========================================
Files 42 42
Lines 16615 16635 +20
Branches 3978 3983 +5
=========================================
+ Hits 1323 1324 +1
- Misses 15269 15288 +19
Partials 23 23
|
Copilot stopped work on behalf of
thomaswilliamsastro due to an error
September 16, 2026 14:23
thomaswilliamsastro
marked this pull request as ready for review
September 17, 2026 15:02
Collaborator
Author
|
@low-sky ready for review! |
thomaswilliamsastro
force-pushed
the
sd-weighting
branch
5 times, most recently
from
October 1, 2026 16:02
0b7807d to
841c2fa
Compare
thomaswilliamsastro
force-pushed
the
sd-weighting
branch
2 times, most recently
from
October 7, 2026 07:08
c497d7e to
75ad42e
Compare
This PR brings in the weight files that the SD pipeline produces, to improve linear mosaicking. - Edit the weight file in the SD pipeline to square what the pipeline spits out, so the weight works as expected - Pull in the SD weight file, if it exists - Stage SD weight file like the SD file - Don't generate weight file if SD weight file already exists - Add explanation for .weight file in docs
thomaswilliamsastro
force-pushed
the
sd-weighting
branch
from
October 7, 2026 07:15
75ad42e to
d1d33f7
Compare
Collaborator
Author
|
@low-sky Added an explanation to the |
e-koch
requested changes
Oct 14, 2026
e-koch
left a comment
e-koch
left a comment
Collaborator
There was a problem hiding this comment.
Added couple comments regarding the naming/whether we can have an option to the do the square operation while linear mosaicking.
e-koch
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the weight files that the SD pipeline produces, to improve linear mosaicking.
Left here is what we had previously, middle is using the weight image as is, right is using weight^2. It's a lot better, and I suspect the last part will be improved with improved baselining