Skip to content

fix: Fix bug when passing foveation config params to ALVR#338

Closed
yoyobuae wants to merge 0 commit into
PhoneVR-Developers:masterfrom
yoyobuae:ffe_config_params_fix
Closed

fix: Fix bug when passing foveation config params to ALVR#338
yoyobuae wants to merge 0 commit into
PhoneVR-Developers:masterfrom
yoyobuae:ffe_config_params_fix

Conversation

@yoyobuae

@yoyobuae yoyobuae commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Before this fix the value of "Center shift X" overwrote the value of "Center Size Width"

@ShootingKing-AM

Copy link
Copy Markdown
Member

The failure is unrelated to this pr (https://github.com/alvr-org/PhoneVR/actions/runs/8824563102/job/24227251352?pr=338#step:12:2735). Seems like the updated macos github-images broke the ci, need to make a NDK setup step. Related to #337 aswell

@ShootingKing-AM

ShootingKing-AM commented Apr 28, 2024

Copy link
Copy Markdown
Member

Can you remake this PR on master @yoyobuae, the CI is updated seems like the me trying to fix the conflict didnt work.

#342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants