Skip to content

Always render the Schoology developer override - #43

Merged
AdamEXu merged 2 commits into
prodfrom
main
Aug 17, 2026
Merged

Always render the Schoology developer override#43
AdamEXu merged 2 commits into
prodfrom
main

Conversation

@AdamEXu

@AdamEXu AdamEXu commented Aug 16, 2026

Copy link
Copy Markdown
Member

The override trigger was gated to non-production web builds, which put it out of reach of the environments it is most needed in. Restores the unconditional render and hides it by painting the label in the slide background colour at 8px with a default cursor.

The override trigger was gated to non-production web builds, which put it
out of reach of the environments it is most needed in. Restore the
unconditional render and hide it by painting the label in the slide
background colour at 8px with a default cursor.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@AdamEXu

AdamEXu commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

@greptileai review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@AdamEXu

AdamEXu commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

bruh what happened to the yc sus 1 year

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@AdamEXu
AdamEXu requested a lite review from Copilot August 16, 2026 23:57
@AdamEXu

AdamEXu commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

guess gotta make do with the copilot review

@AdamEXu

AdamEXu commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

@greptileai pls try again now

This comment was marked as low quality.

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

Restores the Schoology developer override in every onboarding environment while visually concealing its trigger.

  • Removes the production and mobile rendering gates.
  • Keeps the trigger pointer-accessible while hiding it from keyboard navigation and assistive technology.
  • Allows the override dialog to render whenever the trigger is activated.

Confidence Score: 5/5

The PR appears safe to merge because no eligible blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename Overview
frontend/src/components/onboarding/ConnectLmsStep.tsx Unconditionally renders the concealed Schoology developer-override trigger and its dialog across web, mobile, development, and production onboarding.

Reviews (2): Last reviewed commit: "Potential fix for pull request finding" | Re-trigger Greptile

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@AdamEXu
AdamEXu merged commit 5acd670 into prod Aug 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants