feat(dockerfiles): bump base images from v1.11.3 to v1.12.0 in final stages

[wuhuizuo]

No description provided.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary

This pull request updates the base image versions in various Dockerfiles from v1.11.3 to v1.12.0. The changes are simple and consistent across files, affecting only the FROM directives. While the update is straightforward, the lack of a PR description makes it difficult to assess the reasoning behind the change or verify compatibility with the new base images. The update appears well-executed, but further information is needed to ensure there are no underlying issues introduced by the base image change.

---

Critical Issues

• Lack of information about the new base image (v1.12.0):
  • Issue: The PR description does not explain what has changed in the new base image, such as whether there are new dependencies, breaking changes, or performance improvements. This makes it unclear whether the update is safe or has been adequately tested.
  • Suggested Solution: Add a detailed PR description explaining the motivation behind the update, the expected improvements, and any testing done to verify compatibility. For example:

    The update to `v1.12.0` includes security patches, performance improvements, and compatibility updates. All components have been tested against the new base image version to ensure functionality remains intact.
    

---

Code Improvements

• Potential for centralizing base image version management:
  • Affected Files: All Dockerfiles in the diff.
  • Issue: The base image version (v1.12.0) is hardcoded in all Dockerfiles, which may lead to inconsistent updates in the future if not properly managed.
  • Suggested Solution: Use build arguments (ARG) to define the base image version at the top of the Dockerfiles, or manage the version centrally in a shared configuration file. For example:

    ARG BASE_IMAGE_VERSION=v1.12.0
    FROM ghcr.io/pingcap-qe/bases/ng-monitoring-base:${BASE_IMAGE_VERSION}

---

Best Practices

• Testing coverage:

  • Issue: There is no indication in the PR description that the updated images have been tested. Since the base image change could introduce compatibility or dependency issues, verification steps should be documented.
  • Suggested Solution: Provide information on the testing performed, including details like:
    • Were the services built and started successfully using the new base images?
    • Were integration tests run to verify service behavior?
    • Were security vulnerabilities in the new base images reviewed?

• Documentation:

  • Issue: There is no documentation or changelog update to inform developers about the base image upgrade and its implications.
  • Suggested Solution: Update the project's documentation or changelog to reflect this change and provide guidance on how developers can verify compatibility with the updated base images.

---

Conclusion

Although the PR is mechanically correct, the lack of context and documentation raises concerns about the safety and impact of this change. Addressing the critical issues and best practices identified above will ensure that this update is transparent, maintainable, and verifiable.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment