Skip to content

Feature/localization ja#2396

Open
fujimon0722 wants to merge 3 commits into
PixelPlayerHQ:masterfrom
fujimon0722:feature/localization-ja
Open

Feature/localization ja#2396
fujimon0722 wants to merge 3 commits into
PixelPlayerHQ:masterfrom
fujimon0722:feature/localization-ja

Conversation

@fujimon0722

Copy link
Copy Markdown

Hello. I’m a PixelPlayer user from Japan.

I use this project on a daily basis, but since it currently only supports English-speaking regions, I wanted to display the interface in Japanese. I’ve completed the localization and am submitting a pull request.

I’ve been working as a software engineer with languages like C# and TypeScript since before AI became widespread, but lately I’ve been relying almost exclusively on Claude Code and other LLMs to interpret specifications. I also have some experience with Android apps. I reviewed the code based on the commit details. Then, I visually checked for any differences in meaning between the English and Japanese text during the localization process. I also ran tests to ensure that no changes other than the Japanese localization were made.

This is my first time submitting a pull request on GitHub, so I apologize if I’ve violated any rules or been rude in any way.

I hope this contribution from Japan proves useful.

System Requirements

  • OnePlus 12 (Lineage OS 23.2-20260604-NIGHTLY-waffle)
  • ALLDOCUBE iPlay 50 Pro mini (Lineage OS 23.2-20260524-GAPPS-EXT4-GSI) (Debug)
Screenshot_20260618-145202_PixelPlayer Screenshot_20260618-145217_PixelPlayer Screenshot_20260618-145219_PixelPlayer Screenshot_20260618-145221_PixelPlayer Screenshot_20260618-145228_PixelPlayer Screenshot_20260618-145840_PixelPlayer

Copilot AI review requested due to automatic review settings June 18, 2026 06:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Japanese (ja) localization support to PixelPlayer by registering the locale, exposing Japanese as an in-app language option, and providing Japanese string resources across the app’s UI modules.

Changes:

  • Register ja in the app’s locale configuration and app-language enum/options.
  • Add Japanese translations across core UI string resource files (values-ja).
  • Add “Japanese” as a selectable language label in existing translated settings resource files.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/src/main/res/xml/locales_config.xml Adds ja to the app’s declared locale set for Android locale support.
app/src/main/res/values/strings_settings.xml Adds the settings_language_japanese label in the default (English) strings.
app/src/main/res/values-zh-rCN/strings_settings.xml Adds the “Japanese” language label in Simplified Chinese settings strings.
app/src/main/res/values-tr/strings_settings.xml Adds the “Japanese” language label in Turkish settings strings.
app/src/main/res/values-ru/strings_settings.xml Adds the “Japanese” language label in Russian settings strings.
app/src/main/res/values-nb/strings_settings.xml Adds the “Japanese” language label in Norwegian Bokmål settings strings.
app/src/main/res/values-ko/strings_settings.xml Adds the “Japanese” language label in Korean settings strings.
app/src/main/res/values-it/strings_settings.xml Adds the “Japanese” language label in Italian settings strings.
app/src/main/res/values-in/strings_settings.xml Adds the “Japanese” language label in Indonesian settings strings.
app/src/main/res/values-fr/strings_settings.xml Adds the “Japanese” language label in French settings strings.
app/src/main/res/values-es/strings_settings.xml Adds the “Japanese” language label in Spanish settings strings.
app/src/main/res/values-de/strings_settings.xml Adds the “Japanese” language label in German settings strings.
app/src/main/res/values-ja/strings.xml Adds base Japanese translations (common labels, navigation, service, etc.).
app/src/main/res/values-ja/strings_widget.xml Adds Japanese widget-related strings.
app/src/main/res/values-ja/strings_settings.xml Adds Japanese settings UI translations.
app/src/main/res/values-ja/strings_screens.xml Adds Japanese translations for various screens (setup/search/details/etc.).
app/src/main/res/values-ja/strings_player.xml Adds Japanese player/cast/lyrics/queue/sleep-timer strings.
app/src/main/res/values-ja/strings_library.xml Adds Japanese library and related flow strings (sorting, sync, sheets, etc.).
app/src/main/res/values-ja/strings_home_screen.xml Adds Japanese home/stats/beta/crash-report strings.
app/src/main/res/values-ja/strings_equalizer.xml Adds Japanese equalizer UI strings.
app/src/main/res/values-ja/strings_cloud_services.xml Adds Japanese cloud service/auth/dashboard strings.
app/src/main/res/values-ja/strings_changelogs.xml Adds Japanese changelog section labels.
app/src/main/java/com/theveloper/pixelplay/data/preferences/AppLanguage.kt Adds JAPANESE("ja", ...) to supported in-app language options.
.idea/deploymentTargetSelector.xml Removes IDE-specific deployment target selection file from the repo.
Files not reviewed (1)
  • .idea/deploymentTargetSelector.xml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rebornlokii

rebornlokii commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Your PR looks good but why are there conflicts?

PRは良さそうに見えるのに、なぜ利益相反があるのですか?

fujimon0722 and others added 3 commits June 18, 2026 15:25
Translate all 10 string resource files into Japanese (~1,470 strings).
Japanese plurals use quantity="other" only, which covers all cases.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add JAPANESE("ja", R.string.settings_language_japanese) to AppLanguage enum
- Add <locale android:name="ja"/> to locales_config.xml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add the "Japanese" language label in each language's own translation:
en=Japanese, de=Japanisch, es=Japonés, fr=Japonais, in=Jepang,
it=Giapponese, ko=일본어, nb=Japansk, ru=Японский, tr=Japonca, zh=日语

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fujimon0722 fujimon0722 force-pushed the feature/localization-ja branch from 7a54e60 to 0deef6e Compare June 18, 2026 06:25
@fujimon0722

Copy link
Copy Markdown
Author

見落としてました。一旦最新にしました。いかがでしょう?

I missed that. I've updated it to the latest version. How does this look?

@rebornlokii

Copy link
Copy Markdown
Contributor

Everything's good now i think we can merge this PR

すべて問題ないと思います。このプルリクエストは日本語でマージできます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants