feat(place): event scrape

[pkheav]

Looks good to me testing on my local partner environment. Let me know if anything else should be changed or added @w-le @stakach

Also @stakach , might need your help figuring out why these methods

drivers/drivers/place/staff_api.cr

Lines 225 to 242 in 0e234bc

	# TODO: figure out why these 2 methods don't work
	# def module(module_id : String)
	# placeos_client.modules.fetch module_id
	# end
	# def modules(q : String? = nil,
	# limit : Int32 = 20,
	# offset : Int32 = 0,
	# control_system_id : String? = nil,
	# driver_id : String? = nil)
	# placeos_client.modules.search(
	# q: q,
	# limit: limit,
	# offset: offset,
	# control_system_id: control_system_id,
	# driver_id: driver_id
	# )
	# end

don't work as they would be cleaner and probably be a useful addition to staff_api.cr as they're more general than the working methods I added instead

drivers/drivers/place/staff_api.cr

Lines 189 to 219 in 0e234bc

	def module(module_id : String)
	response = get("/api/engine/v2/modules/#{module_id}", headers: {
	"Accept" => "application/json",
	"Authorization" => "Bearer #{token}",
	})
	raise "unexpected response for module id #{module_id}: #{response.status_code}\n#{response.body}" unless response.success?
	begin
	JSON.parse(response.body)
	rescue error
	logger.debug { "issue parsing module #{module_id}:\n#{response.body.inspect}" }
	raise error
	end
	end
	def modules_from_system(system_id : String)
	response = get("/api/engine/v2/modules?control_system_id=#{system_id}", headers: {
	"Accept" => "application/json",
	"Authorization" => "Bearer #{token}",
	})
	raise "unexpected response for modules for #{system_id}: #{response.status_code}\n#{response.body}" unless response.success?
	begin
	JSON.parse(response.body)
	rescue error
	logger.debug { "issue getting modules for #{system_id}:\n#{response.body.inspect}" }
	raise error
	end
	end

.

Oh yeah, tried writing a spec but couldn't get it working as it seems like the spec runner is a little bit flaky.

[kimburgess]

It's unlikely the the server TZ will be the same as the users TZ.

May be worth pulling a larger time slice, then filtering on front-ends, or support passing a timezone either to this method call, or applying as a setting for the driver instance.

[kimburgess]

The #get here will block while each request completes, forcing them to run sequentially. It looks like these could happen safely concurrently.

It should be possible to reorganise this so that you map @zone_ids to an array of Futures (the staff_api.systems(..) call, then combine these into your response.

[kimburgess]

There's a roundtrip through some JSON serialisation here that doesn't look to be required.

[kimburgess]

You may need to expand the staff API driver to support this, but this can collapse into a single query via this endpoint:

https://github.com/PlaceOS/rest-api/blob/5d3acc0cff8d949d360a8f6de9c2e916c52f5cf1/src/placeos-rest-api/controllers/systems.cr#L314-L321