chore(place/visitor_mailer): Default QR generation to FALSE as that i…#507
Open
w-le wants to merge 1895 commits into
Open
chore(place/visitor_mailer): Default QR generation to FALSE as that i…#507w-le wants to merge 1895 commits into
w-le wants to merge 1895 commits into
Conversation
if they are added as a guest accidentally
…, not staff-api. (#462) As kiosk role-based account may not have access to AAD user search.
* feat(placeos/room-events): add list_users func * style(placeos/room-events): format * chore(placeos/room-events): don't parse calendar resp internally Co-authored-by: Stephen von Takach <steve@place.technology> --------- Co-authored-by: Stephen von Takach <steve@place.technology>
also avoids user provided data
reflects the room as checked-in before the meeting starts
for use by authenticated users
as subscription id might change if renewal fails
annoyingly floorsense returns a success response when the request errors
so we can lean on redis more for chat functionality and improve performance
improves performance
don't use a struct if modifying
* feat(lutron): add room logic * fix(lutron): generic_name * fix(lutron/logic): schedule.clear on update
* feat(siemens/desigo): add room logic * fix(desigo/logic): exec command * fix(desigo/logic): read settings * fix(desigo/logic): schedule.clear on update
) * fix(auto_release): [PPT-1392] flip time comparrison for time_after * feat(auto_release): [PPT-1155] add away on leave location to default list of release locations * test(auto_release): tests for most behavior * refactor(auto_release): change default settings * feat(auto_release): align emails with the time_before UI notification * refactor(auto_release): prevent multiple rejections for the same booking
…rect day_of_week numbering, handle last minute changes to bookings (#503) * fix(auto_release): handle preference start/end times crossing midnight * fix(auto_release): correctly handle day_of_week numbers * test(auto_release): last minute changes to bookings * feat(auto_release): check booking status before release to handle last minute changes
…time_after is not set (#504) * test(auto_release): exhaustive tests of #enabled? * fix(auto_release): only disable auto_release if both time_before and time_after are NOT set
* test(auto_release): improve tests * fix(auto_release): use #enabled? for all enabled checks * doc(auto_release): comment time comparison code * feat(auto_release): don't email notifications for already released bookings * refactor(auto_release): only convert start_time to unix timestamp once * refactor(auto_release): only convert start_time to unix timestamp once
…s much more common
stakach
force-pushed
the
place/visitor-mailer/defaults
branch
from
ef3393f to
e8bd237
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply change the default setting for VisitorMailer to NOT send QR emails. As this is the case 90% of the time.