refactor: simplify row compute execution facade - #38
Draft
cursor[bot] wants to merge 9 commits into
Draft
Conversation
Fold postfix chains into a fused RowPlan executed in plasm-runtime, replace the JSON walker, and ship .with{k: expr} with now, len, when, arith (/ and string +), and temporal day diffs.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…RowPlan
Document the new .with{col: expr} postfix in the canonical language definition
(EBNF, invariants, pitfalls) and expand plasm-row-compute with expression
semantics, chaining order, disambiguation, and RowPlan/Polars execution notes.
Add glossary entries for .with and RowPlan.
Co-authored-by: Ryan Roberts <ryan-s-roberts@users.noreply.github.com>
Co-authored-by: Ryan Roberts <ryan-s-roberts@users.noreply.github.com>
Remove unused sort/compare helpers and FieldPath accessors; keep graph stream APIs test-only so lib clippy stays clean. Co-authored-by: Cursor <cursoragent@cursor.com>
Polars owns numeric sort; keep json_scalar_display for template interpolation. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Ryan Roberts <ryan-s-roberts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval_compute_opsandPolarsAdapterto remove dual-path drift.FrameStateoutput-column bookkeeping behind small invariant helpers.Tests
rustfmt --edition 2021 --check crates/plasm-runtime/src/row_compute/eval.rs crates/plasm-runtime/src/row_compute/adapter.rs crates/plasm-runtime/src/row_compute/json_frame.rs crates/plasm-agent-core/src/plasm_plan_run/step_materialize.rs crates/plasm-e2e/tests/plasm_language_matrix.rscargo test -p plasm-runtime row_compute --libcargo test -p plasm-agent-core compute_eval --lib