Align beta editor with GDevelop 5.6.270 and merge feature/breakpoints#3
Conversation
…ian#8696) Only show in developer changelog
Do not show in changelog
…led in the new object dialog (4ian#8708)
…om object or behavior to the extension (4ian#8721)
…l capabilities in the extension editor (4ian#8718)
- Replace the third-party `pixi-spine@4.0.4` with the official Esoteric Software runtime for PixiJS v7 (`@esotericsoftware/spine-pixi-v7@4.2.116`). - The new runtime only fully supports skeletons exported from **Spine 4.2**. Older exports (e.g. 4.0) may partially render but mesh deformations won't work due to a Spine JSON schema change (`deform` → `attachments`).
- Don't show in changelog
…ian#8753) Do not show in changelog
- Add actions to list, delete, check, and duplicate saves - Also adapt actions so they can be awaited
…4ian#8757) * This was causing slow preview times
…and External Layouts (4ian#8756)
Don't show in changelog
…State (4ian#8766) - Don't show in changelog
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![arnica-github-connector[bot]](https://avatars.githubusercontent.com/in/144692?s=60&v=4){kind=small}
| const isRootVariableName = (fullName: string) => | ||
| !fullName.includes('.') && !fullName.includes('[') && fullName.length > 0; |
There was a problem hiding this comment.
Static Code Analysis Risk: Identified pii in JS code
Detected the parameter name fullName in the function isRootVariableName
Severity: Info ℹ️
Status: Open 🔴
References:
More details:
For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk: [arnica] ack <acknowledge additional details>
To dismiss the risk with a reason: [arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and I'm looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
| const isRootVariableName = (fullName: string) => | ||
| !fullName.includes('.') && !fullName.includes('[') && fullName.length > 0; |
There was a problem hiding this comment.
Static Code Analysis Risk: Identified pii in JS code
Detected the parameter name fullName in the function isRootVariableName
Severity: Info ℹ️
Status: Open 🔴
References:
More details:
For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk: [arnica] ack <acknowledge additional details>
To dismiss the risk with a reason: [arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and I'm looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
| "integrity": "sha512-MLaGxr933E5lcH23dFQtCkGNrwl0MRietVCuuanOlO50yCNALrYqH2VUTB12Wt1Zg999Okz+7UBVjpExJYL7hQ==", | ||
| "license": "LicenseRef-LICENSE" | ||
| }, | ||
| "node_modules/@esotericsoftware/spine-pixi-v7": { |
There was a problem hiding this comment.
License Risk: @esotericsoftware/spine-pixi-v7@4.2.116 uses LicenseRef-LICENSE
LicenseRef-LICENSE violates license policy.
Severity: High 🚨
Status: Open 🔴
Suggested reviewers 🧐: @malec-palec
More details:
For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk: [arnica] ack <acknowledge additional details>
To dismiss the risk with a reason: [arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and I'm looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
| "version": "4.0.3", | ||
| "resolved": "https://registry.npmjs.org/@pixi-spine/runtime-4.0/-/runtime-4.0-4.0.3.tgz", | ||
| "integrity": "sha512-2Y8qhxRkg/yH/9VylGsRVAd5W+dXVPhHTjFk0RR9wEUzTCkdZ17pE+56s2nESi2X3sYNKkz8FowfaqIvXnVGxw==", | ||
| "node_modules/@esotericsoftware/spine-pixi-v7": { |
There was a problem hiding this comment.
License Risk: @esotericsoftware/spine-pixi-v7@4.2.116 uses LicenseRef-LICENSE
LicenseRef-LICENSE violates license policy.
Severity: High 🚨
Status: Open 🔴
Suggested reviewers 🧐: @malec-palec
More details:
For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk: [arnica] ack <acknowledge additional details>
To dismiss the risk with a reason: [arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and I'm looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
malec-palec
force-pushed
the
release/beta-editor-5.6.270
branch
from
f72b941 to
15747f2
Compare
5 participants
Summary
release/beta-editoronto upstream GDevelop v5.6.270 (.github/workflows/build-editor.ymlleft untouched, per the beta-editor release process).feature/breakpointson top, bringing in the breakpoints/debugger feature set and its accumulated refactors (compact scene/object properties editors, AI edit-approval flow, adaptive AI polling, editor tabs/panes polish, etc).Details
messages.js/LocalesMetadata.jsfiles resolved by taking the feature branch's (more complete) translations; these are regenerated by the normal extraction pipeline.newIDE/electron-app/app/package.jsonversion kept at the release-pinned value.reloadProjectdeclaration innewIDE/app/src/MainFrame/index.js.Test plan
git greprepo-wide for leftover conflict markers: none found.AiRequestContext.spec.js,AiRequestUtils.spec.js(22/22),EditorFunctions.spec.js(72/72).npm run flow) - long-running on this codebase, recommend running in CI.