fix(nsx): preserve externally-created active LB monitors on pool patch#3
Open
vitaliyzahorenko wants to merge 1 commit into
Open
Conversation
createNsxLbServerPool() replaced LBPool.ActiveMonitorPaths entirely with a single, app-managed monitor path whenever the pool was patched (e.g. on a member list change). Any active monitor attached to the pool outside of this codebase (manually, or by another process) was silently detached on the next update. The pool state already fetched for the member-diff check is now reused to also merge active monitor paths: monitors whose id does not contain the pool name are preserved, and only the app-owned monitor path is added/refreshed. Verified on staging NSX: a manually attached foreign monitor survives a pool member list update.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
createNsxLbServerPool()replacedLBPool.ActiveMonitorPathsentirely with a single, app-managed monitor path whenever the pool was patched (e.g. on a member list change). Any active monitor attached to the pool outside of this codebase (manually, or by another process) was silently detached on the next update.Added
mergeWithForeignActiveMonitorPaths(): keeps any existing monitor whose id does not contain the pool name (same ownership check already used indeleteNsxLbResources), plus the monitor managed by this codebase. Reuses the pool state already fetched for the member-diff check — no extra API call.Verified on staging NSX: manually attached a foreign active monitor to an LB pool, then triggered a member-list update via CloudStack — the foreign monitor remained attached after the patch.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Verified manually on a staging NSX environment: attached a foreign active monitor to an LB pool via the NSX UI, then triggered a member-list update through CloudStack. Confirmed the foreign monitor remained attached to the pool after the patch, and the plugin-managed monitor was correctly refreshed.