Take perspective-python from spaday-perspective - #180
Merged
Conversation
spaday-perspective 0.3.0 declares perspective-python==4.5.2 as a runtime dependency, pinned to the version its browser bundle speaks. Until now it only listed it under develop/examples extras, so raydar had to declare it itself and mirror the compatible range by hand. Drop the direct dependency and take it transitively. The exact upstream pin is tighter than the >=4.5,<4.6 range it replaces, and it can no longer drift out of step with the bundled client. Verified by installing the wheel into a fresh environment: perspective resolves to 4.5.2 with no direct declaration from raydar. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Test Results36 tests 36 ✅ 26s ⏱️ Results for commit 92d2486. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spaday-perspective0.3.0 declaresperspective-python==4.5.2as a runtime dependency, pinned to the version its browser bundle speaks. Previously it listed perspective only under itsdevelop/examplesextras, so raydar had to declare the dependency itself and mirror the compatible range by hand.spaday-perspectiveto>=0.3,<0.4perspective-python>=4.5,<4.6The upstream pin is exact, so it is tighter than the range it replaces and can no longer drift out of step with the bundled client.
Verified by installing the wheel into a fresh environment:
perspective-pythonresolves to 4.5.2 with no direct declaration from raydar, and the dashboard serves. Full suite passes (36) against the new versions.This also makes the open dependabot PR bumping
perspective-pythonto 5.2 moot — raydar no longer pins it, and 5.x would not match the 4.5.2 browser bundle.