Repository navigation
New Entry: always send RDN attribute in Add; AD rDNAttID naming (#24 parity) - #2
Merged
Merged
Conversation
NewEntryDialog.doCreate sent only MUST fields, so an AD group named with cn (MAY via top) was added without cn and the server rejected it. Always attach the RDN attribute=value unless a MUST field already has it. SchemaService now reads classSchema rDNAttID alongside X-NDS_NAMING so the naming combo lists it first. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
Treat the New Entry RDN field as the unescaped attribute value. formatRDN uses UnboundID RDN (RFC 4514) so comma, plus, spaces, hash, and backslash are escaped in the DN; buildCreateAttributes sends the same raw text. Plus is a value character, not a multi-valued RDN. A MUST field that disagrees with the RDN is rejected, and namingEquals is now Objects.equals. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
validateStep1 trims the RDN text and writes it back so Create, the
DN, and the Add all use the same value (" Bob " → cn=Bob). The Step 2
MUST field for that attribute is read-only, matching Arbor, so the
conflict reject path is gone. The editable RDN attribute combo is
checked against an LDAP descr or numeric OID.
Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
JavaFX ComboBox.getValue() can lag typed text until Enter or focus loss, so typing ou and clicking Next could still emit cn. Resolve from the editor first, fall back to getValue, and use that one value for validation, the DN, and the Add. Co-authored-by: Jerry Combs <jcombs@pointbluetech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArborJ parity fix for Arbor issue report #24 (a New Entry Add omitted a MAY RDN attribute such as
cnfor an ADgroup).Changes
buildCreateAttributesalways includes the trimmed RDN value, which wins over a disagreeing field. The Step 2 RDN field is read-only.RDNescaping, and the Add carries the raw value.rDNAttIDbecomes the first naming choice (with SUP inheritance). Attribute names are validated as an RFC 4512 descr or a numeric OID.ou) isn't lost to a stale selection.Verification
mvn test: 136 pass.Follow-ups (backlog):
updateNamingAttributesoverwriting a hand-typed attribute on class change; OID-vs-name MUST matching.