Skip to content

Move further towards KdTreeNanoflann Part B - #6468

Draft
mvieth wants to merge 2 commits into
PointCloudLibrary:masterfrom
mvieth:nanoflann_default6
Draft

Move further towards KdTreeNanoflann Part B#6468
mvieth wants to merge 2 commits into
PointCloudLibrary:masterfrom
mvieth:nanoflann_default6

Conversation

@mvieth

@mvieth mvieth commented Aug 18, 2026

Copy link
Copy Markdown
Member

Work in progress ...

It is now possible to build most of PCL without having FLANN installed (apps, examples, test, benchmarks, and some tutorials still need FLANN and the kdtree module that depends on FLANN). It is still highly recommended to have either FLANN or nanoflann installed. If both are available, PCL auto-selects KdTreeNanoflann by default (faster than KdTree).
This PR

  • adds a new overload for pcl::search::autoSelectMethod where the PointRepresentation to be used can be specified (the other overloads use the default point representation). This overload uses KdTreeNanoflann, KdTree, or BruteForce, depending on what is available.
  • changes KdTreeNanoflann to not inherit from KdTree but from Search directly (KdTree is not available if FLANN is not found)
  • further moves from pcl::search::KdTree to autoSelectMethod in the registration and recognition modules
  • removes the strict requirement of most PCL modules on the kdtree module (no longer required)

@mvieth mvieth added changelog: enhancement Meta-information for changelog generation module: search labels Aug 18, 2026
@mvieth
mvieth force-pushed the nanoflann_default6 branch 13 times, most recently from 38806b0 to 7b8af0f Compare August 22, 2026 09:40
@mvieth mvieth changed the title Move further towards KdTreeNanoflann Move further towards KdTreeNanoflann Part B Aug 23, 2026
@mvieth
mvieth force-pushed the nanoflann_default6 branch 4 times, most recently from fec9bac to 890c441 Compare August 30, 2026 09:56
@mvieth
mvieth force-pushed the nanoflann_default6 branch from 890c441 to 733f050 Compare August 30, 2026 12:15
@mvieth
mvieth requested a lite review from Copilot August 30, 2026 12:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 41 out of 41 changed files in this pull request and generated 5 comments.

Comment thread registration/include/pcl/registration/impl/registration.hpp
Comment thread registration/include/pcl/registration/joint_icp.h Outdated
@mvieth
mvieth force-pushed the nanoflann_default6 branch from 826408c to ff07499 Compare September 1, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Meta-information for changelog generation module: search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants