Keep outlet snapshots and contact details out of browser persistence - #1037
Merged
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outlet windows now keep their billing snapshot in memory instead of writing the complete snapshot to sessionStorage. Existing persisted snapshots are removed on opening. Shop phone details use a volatile store, removing the new clear-text persistence paths identified by code scanning.
Minimize/restore still preserves the existing window and cart. Reloaded windows revalidate register state through the API. Regression checks verify per-window isolation and that shop phone details are absent from browser storage.
Validation: 64 outlet/register/translation tests and 11 settings tests passed; attribution check passed. Full desktop verification is running.