Repository navigation
Bump the desktop-patch-and-minor group across 1 directory with 2 updates - #967
dependabot[bot] wants to merge 1 commit into
Conversation
sridharkalaibala
left a comment
There was a problem hiding this comment.
The jsdom update changes computed font weight from \�old\ to \700, breaking \ ests/receipt-designer.test.js. Please either update the assertion to accept the equivalent computed value or keep jsdom pinned until that compatibility adjustment is tested.
b92318c to
1f86c65
Compare
sridharkalaibala
left a comment
There was a problem hiding this comment.
The refreshed dependency-only update still fails the required Desktop suite: receipt-designer.test.js expects computed font-weight ‘bold’, while jsdom 30.1.1 returns the equivalent canonical value ‘700’. Please include the compatibility assertion update (accepting both equivalent computed forms) in this PR, then rerun the Desktop suite. Also validate the updated transitive packages’ Node engine requirements against the repository’s >=22.12.0 support policy before it is merged.
58c86a3 to
9fa27f0
Compare
sridharkalaibala
left a comment
There was a problem hiding this comment.
This refreshed dependency-only head still fails the required Desktop suite. The failure remains receipt-designer.test.js: jsdom 30.1.1 returns computed font weight ‘700’ while the test expects ‘bold’. Please include the compatibility assertion update (accept either equivalent computed form) and validate the updated dependency tree against the repository's Node >=22.12.0 policy before re-requesting review.
9fa27f0 to
0c7f78b
Compare
sridharkalaibala
left a comment
There was a problem hiding this comment.
The latest refresh still fails the required Desktop suite on the same jsdom computed-font-weight incompatibility (‘700’ versus ‘bold’). Please include and test the compatibility assertion repair before requesting review again; the existing Node >=22.12.0 compatibility validation requirement also remains.
0c7f78b to
e91f4b6
Compare
sridharkalaibala
left a comment
There was a problem hiding this comment.
This refreshed head still fails the required Desktop suite on the same jsdom computed-font-weight mismatch (‘700’ versus ‘bold’). Please include and test the compatibility assertion repair before requesting review again; the Node >=22.12.0 compatibility validation requirement remains.
e91f4b6 to
aa11c38
Compare
sridharkalaibala
left a comment
There was a problem hiding this comment.
This refreshed dependency update is still blocked by the required Desktop suite: the receipt-designer computed-font-weight assertion rejects jsdom’s equivalent \700\ value. It also introduces transitive packages requiring Node ^22.22.2\ (or newer), while this repository supports Node >=22.12.0. Please include the assertion compatibility repair and either preserve the declared Node support floor or explicitly raise and validate the supported runtime policy before re-requesting review.
Bumps the desktop-patch-and-minor group with 2 updates in the / directory: [jsdom](https://github.com/jsdom/jsdom) and [prettier](https://github.com/prettier/prettier). Updates `jsdom` from 30.0.1 to 30.1.1 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v30.0.1...v30.1.1) Updates `prettier` from 3.9.6 to 3.9.9 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.9.6...3.9.9) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: desktop-patch-and-minor - dependency-name: prettier dependency-version: 3.9.8 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: desktop-patch-and-minor ... Signed-off-by: dependabot[bot] <support@github.com>
aa11c38 to
f381d09
Compare
sridharkalaibala
left a comment
There was a problem hiding this comment.
This refreshed head remains blocked by the required Desktop suite’s jsdom computed-font-weight mismatch (\700\ versus \�old). The dependency tree also still requires Node ^22.22.2\ while the repository supports Node >=22.12.0. Please include the compatibility assertion repair and preserve or explicitly update and validate the runtime-support policy before re-requesting review.
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Bumps the desktop-patch-and-minor group with 2 updates in the / directory: jsdom and prettier.
Updates
jsdomfrom 30.0.1 to 30.1.1Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
0a117f430.1.1103f67dRemove unnecessary window cleanup from API testscdda00aTest HTTP/2 document and subresource loading7ab92ceUpdate@asamuzakjp/dom-selectorto v9.2.1d940c20Share jsdom settings across descendant windows6ba40cbFix and simplify option propagation3b3be70Preserve CSS priorities across declaration updates97b2758Align focusing and unfocusing with HTMLb7b460bUpdate w3c-xmlserializer to v671d562fUpdate html-encoding-sniffer to v7Updates
prettierfrom 3.9.6 to 3.9.9Release notes
Sourced from prettier's releases.
Changelog
Sourced from prettier's changelog.
... (truncated)
Commits
cdd17f2Release 3.9.9dc7b896DisablesingleDollarTextMathinmdast-util-math(#20140)f9be58fGit blame ignore 3.9.888470cbBump Prettier dependency to 3.9.89559cabClean changelog_unreleased4fc8ee8Update dependents count4f2ab67Release 3.9.83d82af8Update Regex related dependencies (#20082)5ec8db1[3.9.x] Markdown: Don't let Liquid objects interrupt paragraphs (#20087)5b142edRelease Release@prettier/plugin-hermes@0.2.3,@prettier/plugin-oxc@0.2.3, an...