Keep KOT computers awake and protect saved hardware settings - #998
Merged
Merged
Conversation
…ngs saves Signed-off-by: Sridhar Bala <sridharkalaibala@gmail.com>
Signed-off-by: Sridhar Bala <sridharkalaibala@gmail.com>
Signed-off-by: Sridhar Bala <sridharkalaibala@gmail.com>
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KOT printing now holds the system sleep blocker only while kitchen polling is active. Pausing printing or quitting releases it; screen lock and display sleep remain available. Hardware Manager explains this without moving the cursor or producing paper.
Hardware preferences and KOT configuration flush a temporary JSON file before replacing existing settings, and user saves report write failures. Fix the missing Electron import that hid saved kitchen printer assignments. The uninstaller explicitly explains that Keep my data retains printer selections and hardware settings for test reinstalls; deliberate Delete everything remains respected.
Validation: 70 focused power, settings, installer and Windows printer tests passed. Full desktop run: 3,473 passed, four skipped, three test-harness failures (Windows line endings and an incomplete console mock). Fixed those harnesses and reran both affected files: all 27 tests passed. Document printing persistence tests also passed. Attribution check passed.
No physical idle/reconnect or destructive uninstall was performed on the customer's computer. These changes cannot guarantee USB extender connectivity or recover already deleted settings. Ordinary auto-update and keep-data uninstall already retain the user data directory; the historical reason for this user's missing settings is not established.