Fix cloud approval recovery and Wi-Fi-first setup - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captain could show Approval expired after browser consent when the shop pairing code expired, even while that consent remained valid. Recover once with the same request and PKCE verifier, using the account API recovery deployed in Posnic/web-api#29. Ordinary replay remains forbidden and the approval lifetime is unchanged.
Restore the approved Wi-Fi-first connection screen for first setup and Change server, with visible account sign-in, server address, QR and code choices. Bump Captain to 1.3.28.
Validation: 573 unit tests and 34 onboarding browser tests passed; production web build and 30-language checks passed. Small-screen setup screenshot inspected. The original production cause of the expired code has not been confirmed; the reproduced recovery failure is covered.