Use "project API token" terminology over "API key"#208
Open
gewenyu99 wants to merge 2 commits into
Open
Conversation
Aligns the wording the wizard emits with PostHog's "project API token" terminology. The project token (the public phc_… ingestion key) was being called an "API key" in several skill descriptions and one example app, which is inconsistent with the project-token convention used everywhere else. - Omnibus instrument-* skills: the credential step now asks for the "project API token" rather than the "API key". - mcp-analytics: env var renamed POSTHOG_PROJECT_API_KEY → POSTHOG_PROJECT_TOKEN, prose updated to "project API token". - PHP example app: POSTHOG_API_KEY → POSTHOG_PROJECT_TOKEN, matching every other example app. - Renamed incidental local variables that hold a project token to projectToken (js-web, expo, react-native) for consistency with the node example. Left untouched: genuine personal-API-key references (source-map upload / error tracking, local-evaluation keys, query-API personal keys) and the SDKs' own apiKey / api_key parameter names, which are fixed by the SDK signatures. Why: feedback that the wizard's generated setup labels the project token as an "API key" instead of a token. Generated-By: PostHog Code Task-Id: 870391f2-b0c5-4a20-8534-7dd9607b7a48
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
Member
|
@gewenyu99 I think you need to one more agent sweep. It should be |
Collaborator
Author
|
Oh no API either? |
Per review feedback: PostHog's term is "project token", not "project API token". Drops the "API" word across the omnibus instrument-* skills, mcp-analytics, and the Rails commandment. The MCP `api_token` field name in code is unchanged, and "personal API key" references are untouched. Generated-By: PostHog Code Task-Id: 870391f2-b0c5-4a20-8534-7dd9607b7a48
Collaborator
Author
|
Done in 26ea636 — dropped the "API" so it now reads "project token" (not "project API token") across the omnibus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the wording the wizard emits with PostHog's project API token terminology. The project token (the public
phc_…ingestion key) was being called an "API key" in several skill descriptions and one example app — inconsistent with the project-token convention used everywhere else, and the source of the wizard emittingPOSTHOG_API_KEYinstead of a token.What changed
instrument-*skills (all six): the credential step now asks for the project API token rather than the "API key".mcp-analytics: env varPOSTHOG_PROJECT_API_KEY→POSTHOG_PROJECT_TOKEN; prose → "project API token".POSTHOG_API_KEY→POSTHOG_PROJECT_TOKEN(the lone example app that used the old name).commandments.yaml(Rails): "Store API key…" → "Store the project API token…".projectToken(js-web, expo, react-native) for consistency with the node example.Deliberately left untouched
apiKey/api_key/PostHogConfig(apiKey:)parameter names, which are fixed by the SDK signatures — renaming them would break the code.Why
Feedback that the wizard's generated setup labels the project token as an "API key" instead of a token.
npm test(92 passing) andnpm run buildboth green.Created with PostHog from a Slack thread