fix: mirror django request user agent into $raw_user_agent#729
Draft
lricoy wants to merge 1 commit into
Draft
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix: mirror django request user agent in..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-07-03 15:28:00 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The Django middleware tags all events in a request with
$user_agent, but PostHog's server-side classification — web analytics bot detection ($virt_is_botand friends) and the materialized-column fast path — keys on the standardized$raw_user_agentproperty (the one posthog-js sends). Server-side-tracked pageviews forwarding a real client UA are exactly the traffic where bot classification matters, and today they miss it.PostHog/posthog#68253 removes the
$user_agentquery-time fallback for performance (it forced a full properties-blob read on every classification query — see the PR for production measurements), so this change mirrors the header into$raw_user_agent, aligning the middleware with the standardized property. Related: PostHog/posthog#68232.$user_agentis still sent for backwards compatibility.💚 How did you test it?
Agent-authored. Extended
test_extract_tags_basicto assert both properties carry the request's User-Agent header; ran the middleware extract_tags tests locally (11 passed).📝 Checklist
.sampo/changesets/.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Built with Claude Code as part of a cross-repo effort to standardize on
$raw_user_agent(PostHog/posthog#68232, PostHog/posthog#68253, with sibling PRs to posthog-android and posthog-ruby).